Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: implement push withdrawals (EIP-4895) #25838

Closed
wants to merge 13 commits into from
Closed

all: implement push withdrawals (EIP-4895) #25838

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
774be0e
core/types: add withdrawal type
lightclient Nov 5, 2022
c27745f
core/beacon: add withdrawals and make types version agnostic
lightclient Nov 5, 2022
994b761
eth/catalyst,les/catalyst: add withdrawals and make types version agn…
lightclient Nov 5, 2022
a512496
miner: add withdrawals and update catalyst types
lightclient Nov 5, 2022
7d7fb2f
consensus: process withdrawals
lightclient Nov 5, 2022
58218c9
core/state_processor: finalize with withdrawals
lightclient Nov 5, 2022
72ec036
core/chain_makers: add withdrawal support
lightclient Nov 5, 2022
2ebb038
core/block_validator: verify withdrawals root
lightclient Nov 5, 2022
a6e56c5
core/rawdb: update block readers with new block format
lightclient Nov 5, 2022
a5853bb
eth: add p2p support for withdrawals
lightclient Nov 5, 2022
9ad8070
cmd/evm: support withdrawals in t8n and b11r
lightclient Nov 5, 2022
97c2474
eth/downloader: always use WithBody2 when constructing blocks
lightclient Nov 30, 2022
256e54c
eth/fetcher: always use WithBody2 when constructing blocks
lightclient Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
core/state_processor: finalize with withdrawals
  • Loading branch information
@lightclient
lightclient committed Nov 30, 2022
commit 58218c9b1f03534c100c6424a4de6c39451b3da0
6 changes: 5 additions & 1 deletion core/state_processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,12 @@ func (p *StateProcessor) Process(block *types.Block, statedb *state.StateDB, cfg
receipts = append(receipts, receipt)
allLogs = append(allLogs, receipt.Logs...)
}
// Fail if Shanghai not enabled and len(withdrawals) is non-zero.
if !p.config.IsShanghai(block.Number()) && len(block.Withdrawals()) != 0 {
return nil, nil, 0, fmt.Errorf("non-nil withdrawal before shanghai")
}
// Finalize the block, applying any consensus engine specific extras (e.g. block rewards)
p.engine.Finalize(p.bc, header, statedb, block.Transactions(), block.Uncles())
p.engine.Finalize(p.bc, header, statedb, block.Transactions(), block.Uncles(), block.Withdrawals())

return receipts, allLogs, *usedGas, nil
}
Expand Down