Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse var for getting outputLen #24128

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Reuse var for getting outputLen #24128

merged 1 commit into from
Dec 20, 2021

Conversation

fomotrader
Copy link
Contributor

Instead of recomputing the outputLen reuse existing var that has the length.

@fomotrader
Reuse var for getting outputLen
b5ad65f 
Instead of recomputing the outputLen reuse existing var that has the
length.
gabrielbussolo
gabrielbussolo approved these changes Dec 19, 2021
View reviewed changes
Copy link

@gabrielbussolo gabrielbussolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense for me, doesn't have meaning be repetitive here.

holiman
holiman approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit 99be62a into ethereum:master Dec 20, 2021
@holiman holiman added this to the 1.10.14 milestone Dec 20, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Dec 20, 2021
@fomotrader
accounts/abi: avoid unnecessary alloc (ethereum#24128)
74de573
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
@fomotrader @JacekGlen
accounts/abi: avoid unnecessary alloc (ethereum#24128)
4c16681
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 8, 2025
@fomotrader @gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
29a85e7
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 9, 2025
@fomotrader @gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
7db4479
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@fomotrader @gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
69d517a
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@fomotrader @gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
beb7894
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@fomotrader @gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
247c86e
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Jan 10, 2025
@fomotrader @gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
50b141d
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 14, 2025
@gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
9313fc0
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 16, 2025
@gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
aee7f9b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 17, 2025
@gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
6879457
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025
@gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
1a2bfef
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 22, 2025
@gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
7044f5a
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 23, 2025
@gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
ddc9583
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jan 24, 2025
@gzliudan
accounts/abi: avoid unnecessary alloc (ethereum#24128)
c5acd68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@gabrielbussolo gabrielbussolo gabrielbussolo approved these changes

@NamanJain8 NamanJain8 NamanJain8 approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@MariusVanDerWijden MariusVanDerWijden Awaiting requested review from MariusVanDerWijden MariusVanDerWijden is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.14
Development

Successfully merging this pull request may close these issues.
4 participants
@fomotrader @holiman @gabrielbussolo @NamanJain8