-
Notifications
You must be signed in to change notification settings - Fork 20.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/evm: rename t8n args to improve clarity when tracing #23934
Conversation
Yeah, this is obviously the preferred approach, and we would have done that if we weren't so averse to making API changes. The "proper" way to do this is to have both flags in parallel for a while, and print an error message when the deprecated ( |
f6b7759
to
95b2a38
Compare
Good point @holiman. I added the flags back and marked them as deprecated. I also decided to return an error if the flags are used in a conflicting manner. Not sure you handle situations in the past, but I can remove if you prefer. |
Please add a printout whenever the deprecated flag is used, telling the user to use the new format instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmd/evm/main.go
Apologizes for another PR - my new commits weren't coming through in #23933.
Okay I misunderstood the meaning of the args
tracer.nomemory
andtracer.noreturndata
. I understand now that it is preferred that memory and return data are not printed by default. Given this, I think the flag name are confusing. I didn't realize until looking deeply into this that--tracer.nomemory=false
is a valid argument. I would've assumed the flag did not take a value and was a simple on/off switch, and therefore assumed the correct default behavior for these values should be on. Others have also encountered this.For these reasons, I propose renaming them to
tracer.memory
andtracer.returndata
to avoid the double-negative flagtracer.nomemory=false
.