Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/devp2p/internal: clarify protocol version in tests + more explicit error #23872

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Nov 8, 2021

Debugging recent geth-failures in hive, it took a while to realize that it's because geth doesn't support ETH65 any longer. This PR makes such failures a bit more easy to figure out.

@holiman holiman requested a review from fjl November 8, 2021 15:57
@fjl fjl merged commit 0efed7f into ethereum:master Nov 9, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Nov 9, 2021
…eum#23872)

Debugging recent geth failures in hive, it took a while to realize that it's because
geth doesn't support eth/65 any longer. This PR makes such failures a bit more
easy to figure out.
@holiman holiman deleted the hivefixes branch November 10, 2021 18:32
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
…eum#23872)

Debugging recent geth failures in hive, it took a while to realize that it's because
geth doesn't support eth/65 any longer. This PR makes such failures a bit more
easy to figure out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants