eth, les: fix sendTransaction API in the light mode #23215
Conversation
rjl493456442
requested review from
holiman,
karalabe and
zsfelfoldi
as code owners
les/api_backend.go
Outdated
| @@ -125,8 +127,18 @@ func (b *LesApiBackend) BlockByNumberOrHash(ctx context.Context, blockNrOrHash r | |||
| return nil, errors.New("invalid arguments; neither block nor hash specified") | |||
| } | |||
|
|
|||
| func (b *LesApiBackend) PendingBlockAndReceipts() (*types.Block, types.Receipts) { | |||
| return nil, nil | |||
| func (b *LesApiBackend) PendingBlockAndReceipts(ctx context.Context) (*types.Block, types.Receipts, error) { | |||
There was a problem hiding this comment.
I don't think this is necessary or a good idea. It's fine to revert the HeaderByNumber behavior to the original version (so that specifying pending returns latest) but this function explicitly targets the pending block and it's super weird to pass a context and return an error just so that it can return latest in light mode, then add a light flag to the oracle to ensure that we never actually call this function in light mode :)
Now I think the only fix needed is to revert HeaderByNumber behavior. The first version of the FeeHistory API function depended on this change but now it uses PendingBlockAndReceipts for pending (it never calls HeaderByNumber for pending block). So if we just leave PendingBlockAndReceipts as is (no need to add a light flag to the oracle either) and just revert HeaderByNumber then we should be fine and the code would be simpler.
There was a problem hiding this comment.
Yes, I agree. The HeaderByNumber revert is enough for fixing. But when I implement this PR, I want to align the behavior that in the light mode we have no pending thing. It might be cleaner for the long term and whenever we introduce the pending things into the light client we can change it.
But I can use the simpler version for the fix if you think it's enough. But i think it's still needed to align the behavior.
rjl493456442
force-pushed
the
fix-sendtx-light
branch
from
ef5b5bc to
a63b569
Compare
This PR fixes the
eth_sendTransactionAPI in the light mode. More detail in #23214