Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

les/vflux/server: fix metrics #22946

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Conversation

rjl493456442
Copy link
Member

This PR fixes the incorrect LES metrics.

@rjl493456442 rjl493456442 requested a review from zsfelfoldi as a code owner May 26, 2021 07:38
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman
Copy link
Contributor

holiman commented May 31, 2021

linter says no

les/vflux/server/metrics.go:26:2: `totalInactiveCountGauge` is unused (deadcode)

	totalInactiveCountGauge  = metrics.NewRegisteredGauge("vflux/server/inactive/count", nil)

@rjl493456442
Copy link
Member Author

@holiman fixed

@holiman holiman merged commit 088bc34 into ethereum:master Oct 11, 2021
@holiman holiman added this to the 1.10.10 milestone Oct 11, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 11, 2021
* les/vflux/server: fix metrics

* les/vflux/server: fix metrics
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
* les/vflux/server: fix metrics

* les/vflux/server: fix metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants