Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/fetcher: discard block 0 notifications #22658

Merged
merged 1 commit into from
Oct 31, 2021
Merged

Conversation

r1cs
Copy link
Contributor

@r1cs r1cs commented Apr 13, 2021

if notification.number is invalid, we chould break this select, the old logic will also continue.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if notification.number is invalid, we chould break this select, the old logic will also continue.
@holiman holiman added this to the 1.10.12 milestone Oct 29, 2021
@holiman holiman changed the title optimize the judge of invalide notification.number eth/fetcher: discard block 0 notifications Oct 29, 2021
@holiman holiman merged commit 410e731 into ethereum:master Oct 31, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Nov 1, 2021
Don't bother fetching genesis

Co-authored-by: wuff1996 <[email protected]>
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
Don't bother fetching genesis

Co-authored-by: wuff1996 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants