les: rename lespay to vflux #22347
Merged
les: rename lespay to vflux #22347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
force-pushed
the
rename-lespay
branch
from
3310087 to
b076541
Compare
les/client.go
Outdated
| @@ -263,9 +263,9 @@ func (s *LightEthereum) APIs() []rpc.API { | |||
| Service: NewPrivateLightAPI(&s.lesCommons), | |||
| Public: false, | |||
| }, { | |||
| Namespace: "lespay", | |||
| Namespace: "vfx", | |||
There was a problem hiding this comment.
I think vflux perhaps is better? It's a common name in client side vfc and server side vfs
zsfelfoldi
force-pushed
the
rename-lespay
branch
from
b076541 to
2df0889
Compare
zsfelfoldi
force-pushed
the
rename-lespay
branch
from
2df0889 to
dfbb6df
Compare
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames package lespay because that name did not sound good and was hard to say. Now I think we should separate three distinct things related to incentivization. There is the protocol (LES), the market mechanics and the payment channel. The economic model and market mechanics are not strictly tied to either the LES protocol or the payment channel technology. So I think the payment technology can be called LotteryBook (I think Gary gave it this name and I like it). For the market mechanics and the underlying model I had a few name ideas earlier, currently I think I'd like to call it "variflux" or "vflux", "vfx" for short. The reasoning behind it is that it models the network as a flow graph with constantly varying capacities. Also I think it sounds better and it's easy to abbreviate and the abbreviations sound ok too. The talk request ID of the UDP protocol could also be "vfx".
If you don't like it then I'm still somewhat open to suggestions, though this is the part that I primarily consider my own brainchild and I'd like to have a say in naming it :)
Note: "lespayDb" is not renamed in this PR because it is already renamed in another one.