Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: deprecate Client.ShhSubscribe #22239

Merged
merged 3 commits into from
Jan 27, 2021
Merged

rpc: deprecate Client.ShhSubscribe #22239

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c872bdf
rpc: Remove whisper subscription
gballet Jan 26, 2021
2e49c37
deprecate ShhSubscribe instead
gballet Jan 27, 2021
ec2ec94
Update client.go
fjl Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
rpc: Remove whisper subscription
  • Loading branch information
@gballet
gballet committed Jan 26, 2021
commit c872bdf41f44597b5b582cdc2fea45449f317e50
5 changes: 0 additions & 5 deletions rpc/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,11 +413,6 @@ func (c *Client) EthSubscribe(ctx context.Context, channel interface{}, args ...
return c.Subscribe(ctx, "eth", channel, args...)
}

// ShhSubscribe registers a subscripion under the "shh" namespace.
func (c *Client) ShhSubscribe(ctx context.Context, channel interface{}, args ...interface{}) (*ClientSubscription, error) {
return c.Subscribe(ctx, "shh", channel, args...)
}

// Subscribe calls the "<namespace>_subscribe" method with the given arguments,
// registering a subscription. Server notifications for the subscription are
// sent to the given channel. The element type of the channel must match the
Expand Down