core/rawdb: add ability to retrieve freezer data iteratively #20308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
commented
Nov 18, 2019
| ) | ||
| current := start | ||
| for nItems < max { | ||
| nextStart, nextEnd, nextFile, err := t.getBounds(current) |
There was a problem hiding this comment.
If we really want to go nuts, we can optimize this too and do t.getBoundsN, to read n index entries in one go. But I'll leave that for later/someone else
|
Closing this, it's currently not used -- I experimented with it on the reinitialize-chain-from-ancients. It shaved off a bit of time, but since the big bottleneck is that we also need to write stuff to leveldb, it doesn't really motivate the added complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not change any existing functionality in go-ethereum, but does add a new Api-method on freezertable, which might be useful in the future.
The
RetrieveNmethod fetches the data from the underlying datastore in one disk-access, and returns the result in an iterator.The idea is that instead of doing 8M disk accesses for e..g iterating the canon hashes, we can do a few orders of magnitude less disk accesses.
This can be useful in the following scenarios: