Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: make transaction tests run again, fix #19033 #19529

Merged
merged 2 commits into from
May 21, 2019
Merged

tests: make transaction tests run again, fix #19033 #19529

merged 2 commits into from
May 21, 2019

Conversation

holiman
Copy link
Contributor

@holiman holiman commented May 5, 2019 •
edited
Loading

This PR fixes our transaction tests to actually run the tests (see #19033 ).

@holiman
Copy link
Contributor Author

holiman commented May 6, 2019

Not WIP anymore, PTAL

@holiman holiman requested a review from karalabe May 6, 2019 08:17
karalabe
karalabe approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assume it's correct :) Can't be worse than it was until now :P

@karalabe karalabe added this to the 1.9.0 milestone May 21, 2019
@karalabe karalabe merged commit 2cd6059 into ethereum:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

Assignees

@fjl fjl

Labels
None yet
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@holiman @karalabe @fjl