Clef: USB hw wallet support #17756
Merged
Clef: USB hw wallet support #17756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagydani
approved these changes
Sep 27, 2018
|
I agree, the future plan is to either make it a flag, but the real fix is to make it configurable from the UI. That requires a bidirectional commnication channel, which our current RPC implementation does not support (the json-rpc protocol supports it though) I did it this way for now, since it's easy and I didn't want to add another flag that will be removed soon:ish anyway |
|
Rebased to get travis working again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports USB hardware wallets like Trezor over to Clef. Since Clef does not have access to state, it auto-derives a number of accounts (currently hardcoded to
10).It also adds a new internal API-call to ask the UI for a trezor PIN.