internal: fix downloader synchronising judgement #16238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
force-pushed
the
fix_syncing
branch
from
367ec48 to
0e4ec68
Compare
rjl493456442
force-pushed
the
fix_syncing
branch
from
0e4ec68 to
d5c3458
Compare
karalabe
requested changes
Mar 7, 2018
There was a problem hiding this comment.
Please split the PR into two ones, one for the highest block fix, the other for the state commit fix.
The highest block issue is a good catch, but the fix is not in my opinion. Many outside processes will consider the client synced if the HighestBlock == CurrentBlock. We don't want to do that. Instead, lets fix syncStatsChainHeight. Imho the best way would be to add an extra clause inside processHeaders after https://github.com/ethereum/go-ethereum/blob/master/eth/downloader/downloader.go#L1297 to bump syncStatsChainHeight to the last header if a higher one was found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the
fast sync, the pivot point may move if the pivot block is stale. So the original judgement is inaccurate if the pivot point is moved.We should judgement whether downloader is in work or not always by the
synchronisingstatus flag.