Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swarm: creates Swarm landing page for browser 'localhost:xxxx/' GET request when running Swarm #15926

Merged
merged 8 commits into from
Feb 26, 2018
Merged

swarm: creates Swarm landing page for browser 'localhost:xxxx/' GET request when running Swarm #15926

merged 8 commits into from
Feb 26, 2018

Conversation

cooganb
Copy link
Contributor

@cooganb cooganb commented Jan 19, 2018

This PR creates a landing page when swarm user directs browser to localhost:xxxx/. Currently, such a GET request results in browser returning Error Code: 400.

This PR has been approved by 3 members of the Swarm team in ethersphere#190

It is part of improving the http interface of the Swarm experience. Please let me know if you have any questions and thank you for your time in advance!

@GitCop
Copy link

GitCop commented Jan 19, 2018

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: 67f30e344553bdc95114aa9965e4016426c34329

  • Commits must be prefixed with the package(s) they modify

  • Commit: 62cd63505b039ff80d216bf84aace9791b979bbb

  • Commits must be prefixed with the package(s) they modify

  • Commit: 03273342bdbadb58dfc6de98e86b228d857e9ba2

  • Commits must be prefixed with the package(s) they modify

  • Commit: 4225ab0c235558a569ac787a102f850427641f56

  • Commits must be prefixed with the package(s) they modify

  • Commit: 848b782a73ec58303b26140ff5474423dd2c478b

  • Commits must be prefixed with the package(s) they modify

  • Commit: 1ab4348ebe11fe727dc22983eb2e78c4baf13f1b

  • Commits must be prefixed with the package(s) they modify

  • Commit: c77dae0e960149326bf9c0ff3d53b1990d827273

  • Commits must be prefixed with the package(s) they modify

  • Commit: 88feaafc59420624e6fb6de857dcb072762cea1d

  • Commits must be prefixed with the package(s) they modify

  • Commit: cfad66309c4d397771a3232d8e07903d3495c07a

  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.

This message was auto-generated by https://gitcop.com

@cooganb cooganb force-pushed the swarm-blank-reply-200 branch from cfad663 to 78fabc8 Compare January 19, 2018 18:56
@cooganb cooganb changed the title Swarm: creates Swarm landing page for browser 'localhost:xxxx/' GET request when running Swarm swarm: creates Swarm landing page for browser 'localhost:xxxx/' GET request when running Swarm Jan 19, 2018
@cooganb cooganb force-pushed the swarm-blank-reply-200 branch from 78fabc8 to f096d85 Compare January 20, 2018 01:08
@cooganb cooganb mentioned this pull request Jan 23, 2018
Merged
holiman
holiman approved these changes Jan 24, 2018
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If approved by swarm-team, LGTM

@cooganb cooganb force-pushed the swarm-blank-reply-200 branch from 49fe91d to e57c23c Compare February 23, 2018 19:43
@gbalint gbalint added this to the 1.8.2 milestone Feb 26, 2018
@gbalint gbalint merged commit 22fc692 into ethereum:master Feb 26, 2018
prestonvanloon pushed a commit to prestonvanloon/go-ethereum that referenced this pull request Apr 2, 2018
@cooganb @prestonvanloon
swarm: creates Swarm landing page for browser 'localhost:xxxx/' GET r…
8fc66c1 
…equest when running Swarm (ethereum#15926)

* swarm: began work on GetHandleFile method re: issue ethereum#155

* swarm: now able to serve landing page template

* swarm: added landing page template

* swarm: landing page has working input

* swarm: fixed CSS issue in template

* swarm: deleted extra lines

* swarm: deleted time header and made redirect a relative path

* swarm: removed code mistakenly left
mariameda pushed a commit to NiluPlatform/go-nilu that referenced this pull request Aug 23, 2018
@cooganb @mariameda
swarm: creates Swarm landing page for browser 'localhost:xxxx/' GET r…
9431e77 
…equest when running Swarm (ethereum#15926)

* swarm: began work on GetHandleFile method re: issue ethereum#155

* swarm: now able to serve landing page template

* swarm: added landing page template

* swarm: landing page has working input

* swarm: fixed CSS issue in template

* swarm: deleted extra lines

* swarm: deleted time header and made redirect a relative path

* swarm: removed code mistakenly left
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@fjl fjl Awaiting requested review from fjl

@karalabe karalabe Awaiting requested review from karalabe

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi

Assignees

@cooganb cooganb

Labels
type:feature
Projects
None yet
Milestone
1.8.2
Development

Successfully merging this pull request may close these issues.
5 participants
@cooganb @GitCop @holiman @gbalint @zelig