core: make genesis incompatibility error more explicit #14358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14352 (and a lot reports about the same thing from gitter).
Previously users were allowed to reinit an already inited chain, overwriting the genesis block (and nothing else). This was deemed dangerous potentially leading to data loss, so starting from Geth 1.6.0 we rejected such attempts with an error message
wrong genesis block in database (have ..., want ...). Unfortunately this error message isn't very useful for an end user, as it doesn't really say how to fix the problem.This PR changes the error message to make it more use friendly by explicitly stating that there's already a genesis block inside the database, and that is not compatible with the one you try to reinit with.