-
Notifications
You must be signed in to change notification settings - Fork 20.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth_transact not returning an address for a new contract #407
Comments
Are you using the RPC directly? Creating the contract via ethereum.js works fine for me here:
|
Yeah using the RPC directly. I now get a result back after I wiped out my database... |
Closing as I can't reproduce it anymore. @maran thanks for verifying! |
ngtuna
pushed a commit
to ngtuna/tomochain
that referenced
this issue
Jan 15, 2019
fix bug receipt status
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this issue
Jan 20, 2022
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this issue
Dec 9, 2022
Added logging for statesyncs data
tanishqjasoria
pushed a commit
to tanishqjasoria/go-ethereum
that referenced
this issue
Oct 31, 2023
* add proof for predeployed storages * reverse inneeded code * update for mainbranch merging * add pertx storage trace * dummy tx proof * add txstorage trace * add coinbase storage as trace * enable (sync) tracing by default * basic * init cgo framework * fix break loop * integrate the right zkevm version (ethereum#323) * finish rust codes * use dylib (ethereum#325) * flip * ? * use cdylib * revert * fix * apply_tx * rename * fixing types fixing types fixing types * clean up * ExecutionResults (ethereum#328) * filling * filling * more * clean up * filling * coinbase * add * MPTWitness * ExecutionResults WIP * L1fee L1fee * sender * to * Failed & ReturnValue * createdAcc & after * remove MPTWitness * txStorageTrace * add FeeRecipient * add StorageTrace * fix FFI types * better logger * cargo fmt * fix * add build tags * update Makefile * fix library * improve ld path * correctly deal with circuit_capacity_checker returned result * fix return value * update cargo (ethereum#333) * update cargo * update * update go * refactor * raname `circuits capacity checker` to `circuit capacity checker` * some refactorings * [Fix] storage proof generation in capacity checker (ethereum#348) * make per-tx storage and deletion proof work * format * fix misplaced markdeletion --------- Co-authored-by: HAOYUatHZ <[email protected]> * docker (ethereum#363) * update Dockerfile * build: update go version to 1.19 * update * fix * fix * try * simplify * revert go version update l2geth Dockerfiles * fix * fix coinbase * fix (ethereum#369) * format * Update version.go * address comments * Capacity refactor (ethereum#374) * init * id * support multiple instances * fix id * fix conflicts * refactor to use same codes (ethereum#379) * re-init * WIP * WIP * refactor * go * minor * fix storage proof of l1gas price oracle * move 1 * move 2 * move 3 * move 4 * move 5 move 5 * move 6 move 6 * move 7 * move 8 * move 9 * move 10 * clean up clean up --------- Co-authored-by: Ho Vei <[email protected]> * finish basic * minor * config capacity check in block_validator (ethereum#380) * init * done ref * fix tests fix tests fix tests fix tests * add more comments * apply_block * improve logs * cargo fmt * Capacity big refactor (ethereum#383) * CreateTraceEnv * WIP * draft more fix * for test * fortet * clean up * add more comments * goimports -local github.com/scroll-tech/go-ethereum -w . * fix typos * attempt 1 * attempt 2 * attempt 3 * gogogo * clean up * fix * fix * rename * minor * fix * minor * minor * improve doc * use dedicated `checkCircuitCapacity` flag (ethereum#394) * refactor * fix * add lock * [feat] capacity checking: upgrade libzkp (ethereum#395) * upgrade * upgrade libzkp * write RowConsumption (ethereum#396) * write RowConsumption * name alignments * revert some formatting * add lock to CircuitCapacityChecker in BlockValidator * remove mutex pointer * improve github workflow * improve * store row consumption in mining (ethereum#397) * prepare * finish * add more logs * mark `ApplyBlock` as ready * update libzkp (ethereum#401) * fix * Capacity detail (ethereum#402) * fix(block-validation): consider skipping in ValidateL1Messages (ethereum#405) * fix(block-validation): consider skipping in ValidateL1Messages * fix(block): consider skipping in L1MessageCount * fix l1 validation tests * fix NumL1Messages * fix impl.go return types fix * better error handling (ethereum#407) * add add * add * add * add * add * cargo fmt * add * update * add * WIP * minor * gogogo * gogogo * fix * fix * fix * cargo clippy * improve * improve * creation lock (ethereum#408) * creation lock * update * Debug log (ethereum#409) * add more logs * more * more * fix * improve * Update cmd/utils/flags.go Co-authored-by: Péter Garamvölgyi <[email protected]> * refactor worker.commit() * avoid re-calculate * txpool ccc err handling (ethereum#411) * more explicit error comments * add more logs * fix unnecessary commit * add more logs * fix `ineffassign` * add more comments * log id for `NewCircuitCapacityChecker` (ethereum#414) add log to `NewCircuitCapacityChecker` * Persist skip info for block where all L1 msgs are skipped (ethereum#415) persist skip info for block where all L1 msgs are skipped * Update version.go --------- Co-authored-by: Ho Vei <[email protected]> Co-authored-by: Zhang Zhuo <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]>
tanishqjasoria
pushed a commit
to tanishqjasoria/go-ethereum
that referenced
this issue
Apr 5, 2024
tanishqjasoria
pushed a commit
to tanishqjasoria/go-ethereum
that referenced
this issue
Apr 11, 2024
garyschulte
pushed a commit
to garyschulte/go-ethereum
that referenced
this issue
Apr 17, 2024
* simplified gas accounting layer * integrate some review feedback * Apply suggestions from code review Co-authored-by: Ignacio Hagopian <[email protected]> * more suggestions from code review * don't charge creation gas + charge code chunks in create * A couple more fixes * make linter happy * fix create init gas consumption issue * fix: in gas funcs, use tx witness instead of global witness * fix linter issue * Apply suggestions from code review Co-authored-by: Ignacio Hagopian <[email protected]> * fix: EXTCODECOPY gas consumption * fix warm gas costs * fix the order gas is charged in during contract creation epilogue * fix selfdestruct * fix ethereum#365 in eip rewrite (ethereum#407) * fix: OOG type in code creation OOG (ethereum#408) * core/vm: charge BLOCKHASH witness cost (ethereum#409) * core/vm: charge BLOCKHASH witness cost Signed-off-by: Ignacio Hagopian <[email protected]> * remove gas optimization for now Signed-off-by: Ignacio Hagopian <[email protected]> --------- Signed-off-by: Ignacio Hagopian <[email protected]> * remove redundant logic for contract creation (ethereum#413) Signed-off-by: Ignacio Hagopian <[email protected]> * fix precompile address check for charging witness costs & fix missing value-bearing rule (ethereum#412) Signed-off-by: Ignacio Hagopian <[email protected]> * core/vm: fix wrong check (ethereum#416) Signed-off-by: Ignacio Hagopian <[email protected]> * charge for account creation if selfdestruct creates a new account (ethereum#417) * add key comparison test (ethereum#418) * core/vm: charge contract init before execution logic (ethereum#419) * core/vm: charge contract init before execution logic Signed-off-by: Ignacio Hagopian <[email protected]> * fix CREATE2 as well --------- Signed-off-by: Ignacio Hagopian <[email protected]> Co-authored-by: Guillaume Ballet <[email protected]> * quell linter --------- Signed-off-by: Ignacio Hagopian <[email protected]> Co-authored-by: Ignacio Hagopian <[email protected]>
s1na
pushed a commit
to s1na/go-ethereum
that referenced
this issue
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running
ethereum
withethereum -mine=true -rpc=true -loglevel=5 -bootnodes="" -nat=none -dial=false
Build 65cad14 on OSX.
Simple Serpent contract to test with:
This compiles to:
Creating the contract via an RPC call:
I would expect the contract address to be returned instead of an empty string.
The text was updated successfully, but these errors were encountered: