Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEC-11 Uncle validation does not correctly implement is-kin property #387

Closed
Gustav-Simonsson opened this issue Feb 25, 2015 · 1 comment
Closed

SEC-11 Uncle validation does not correctly implement is-kin property #387

Gustav-Simonsson opened this issue Feb 25, 2015 · 1 comment
Milestone
Frontier

Comments

@Gustav-Simonsson
Copy link

The yellow paper equation 131 defines the "is-kin" property. Currently this is not correctly implemented, in the AccumulateRewards function at https://github.com/ethereum/go-ethereum/blob/develop/core/block_processor.go#L280

Specifically, it must check that the uncle hash is not one of the ancestors.

Also: the AccumulateRewards function accepts uncles which are siblings - share the same parent hash as the current block.
@obscuren
Copy link
Contributor

Add

ancestors.Has(uncle.Hash())

This was referenced Feb 28, 2015
Closed
Closed
@obscuren obscuren modified the milestone: Frontier Mar 9, 2015
@obscuren obscuren closed this as completed Mar 9, 2015
jpeletier pushed a commit to epiclabs-io/go-ethereum that referenced this issue Apr 22, 2018
@holisticode
Merge pull request ethereum#387 from holisticode/swarm-network-rewrit…
54c354b 
…e-retrieval-test

swarm: implemented retrieval test
ngtuna added a commit to ngtuna/tomochain that referenced this issue Jan 5, 2019
@ngtuna
Merge pull request ethereum#387 from dinhln89/min_tomo
95b360f 
Fixed minimum gas used when deploy SMC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Frontier
Development

No branches or pull requests
2 participants
@Gustav-Simonsson @obscuren