Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/bn256: compile error #24439

Closed
millken opened this issue Feb 21, 2022 · 1 comment · Fixed by #24476
Closed

crypto/bn256: compile error #24439

millken opened this issue Feb 21, 2022 · 1 comment · Fixed by #24476
Assignees
@MariusVanDerWijden
Labels
type:bug

Comments

@millken
Copy link

millken commented Feb 21, 2022

OS & Version: Debian11 / Go1.17.7

Use Go1.16 can be compiled

# github.com/ethereum/go-ethereum/crypto/bn256/cloudflare
asm: gfp_amd64.s:52: when dynamic linking, R15 is clobbered by a global variable access and is used here: 00020 (/home/millken/.gvm/pkgsets/go1.17.7/global/pkg/mod/github.com/ethereum/[email protected]/crypto/bn256/cloudflare/gfp_amd64.s:52)      SBBQ    "".p2+24(SB), R15
asm: gfp_amd64.s:71: when dynamic linking, R15 is clobbered by a global variable access and is used here: 00057 (/home/millken/.gvm/pkgsets/go1.17.7/global/pkg/mod/github.com/ethereum/[email protected]/crypto/bn256/cloudflare/gfp_amd64.s:71)      CMOVQCC R15, R10
asm: gfp_amd64.s:124: when dynamic linking, R15 is clobbered by a global variable access and is used here: 00578 (/home/millken/.gvm/pkgsets/go1.17.7/global/pkg/mod/github.com/ethereum/[email protected]/crypto/bn256/cloudflare/gfp_amd64.s:124)    CMOVQCC R11, R15
asm: assembly failed
@MariusVanDerWijden
Copy link
Member

I'll take a look
Repro: go build --buildmode=shared ./crypto/bn256/cloudflare/
Fix: use a different register

@MariusVanDerWijden MariusVanDerWijden self-assigned this Feb 24, 2022
uji added a commit to uji/go-ethereum that referenced this issue Feb 27, 2022
@uji
crypto/bn256/cloudflare: fix asm for dynamic linking
404a995 
when dynamic linking, R15 is clobbered by a global variable access and is used here; avoid them.

Fixes: ethereum#24439
@uji uji mentioned this issue Feb 27, 2022
Merged
@fjl fjl closed this as completed in #24476 Mar 8, 2022
fjl pushed a commit that referenced this issue Mar 8, 2022
@uji
crypto/bn256/cloudflare: fix asm for dynamic linking (#24476)
ec64358 
When using -buildmode=shared, R15 is clobbered by a global variable
access; use a different register instead.

Fixes: #24439
sidhujag pushed a commit to syscoin/go-ethereum that referenced this issue Mar 9, 2022
@uji
crypto/bn256/cloudflare: fix asm for dynamic linking (ethereum#24476)
89c68d7 
When using -buildmode=shared, R15 is clobbered by a global variable
access; use a different register instead.

Fixes: ethereum#24439
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this issue May 26, 2022
@uji @JacekGlen
crypto/bn256/cloudflare: fix asm for dynamic linking (ethereum#24476)
7a52b75 
When using -buildmode=shared, R15 is clobbered by a global variable
access; use a different register instead.

Fixes: ethereum#24439
cp-wjhan pushed a commit to cp-yoonjin/go-wemix that referenced this issue Nov 16, 2022
@uji @cp-wjhan
crypto/bn256/cloudflare: fix asm for dynamic linking (ethereum#24476)
55fc626 
When using -buildmode=shared, R15 is clobbered by a global variable
access; use a different register instead.

Fixes: ethereum#24439
wgr523 pushed a commit to XinFinOrg/XDPoSChain that referenced this issue Jan 18, 2024
@uji @wgr523
crypto/bn256/cloudflare: fix asm for dynamic linking (ethereum#24476)
d4b9806 
When using -buildmode=shared, R15 is clobbered by a global variable
access; use a different register instead.

Fixes: ethereum#24439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MariusVanDerWijden MariusVanDerWijden

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crypto/bn256/cloudflare: fix asm for dynamic linking uji/go-ethereum
2 participants
@millken @MariusVanDerWijden