Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geth console unresponsive when running js statement #23344

Closed
lightclient opened this issue Aug 6, 2021 · 1 comment · Fixed by #23387
Closed

Geth console unresponsive when running js statement #23344

lightclient opened this issue Aug 6, 2021 · 1 comment · Fixed by #23387
Assignees
@holiman
Labels
type:bug

Comments

@lightclient
Copy link
Member

lightclient commented Aug 6, 2021 •
edited
Loading

I would expect to be able to stop a statement (e.g. a loop) with Ctrl+C or Ctrl+D, but it just carries right along.
@gballet
Copy link
Member

gballet commented Aug 11, 2021 •
edited
Loading

Ctrl+D would be a counter-intuitive key combination for interrupting a statement. Ctrl+C is the right key combination, but is already mapped to quitting geth.

One idea would be to change the semantics of Ctrl+C to:

  • When using the console command, interrupt the running js statement. Ctrl+D then quits geth, as it does in other command line tools like shells or script interpreters.
  • Outside of console mode, quit geth.

EDIT: Ctrl+D already has the expected behavior, so the issue is with Ctrl+c

holiman added a commit to holiman/go-ethereum that referenced this issue Aug 12, 2021
@holiman
cmd/geth, console: support interrupting the js engine, fixes ethereum…
148d25b 
…#23344
s1na pushed a commit to s1na/go-ethereum that referenced this issue Dec 2, 2021
@holiman @s1na
cmd/geth, console: support interrupting the js engine, fixes ethereum…
d74dc71 
…#23344
@fjl fjl mentioned this issue Dec 11, 2021
Merged
fjl added a commit that referenced this issue Dec 11, 2021
@holiman @s1na @fjl
cmd/geth, console: support interrupting the js console (#23387)
72c2c0a 
Previously, Ctrl-C (SIGINT) was ignored during JS execution, so it was not
possible to get out of infinite loops in the console. With this change,
Ctrl-C now interrupts JS.

Fixes #23344

Co-authored-by: Sina Mahmoodi <[email protected]>
Co-authored-by: Felix Lange <[email protected]>
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this issue May 26, 2022
@holiman @s1na
@fjl @JacekGlen
cmd/geth, console: support interrupting the js console (ethereum#23387)
ce00d2f 
Previously, Ctrl-C (SIGINT) was ignored during JS execution, so it was not
possible to get out of infinite loops in the console. With this change,
Ctrl-C now interrupts JS.

Fixes ethereum#23344

Co-authored-by: Sina Mahmoodi <[email protected]>
Co-authored-by: Felix Lange <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holiman holiman

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/geth, console: support interrupting the js console holiman/go-ethereum
4 participants
@karalabe @holiman @gballet @lightclient