Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package naming scheme #153

Closed
10 of 11 tasks
obscuren opened this issue Oct 27, 2014 · 3 comments
Closed
10 of 11 tasks

Package naming scheme #153

obscuren opened this issue Oct 27, 2014 · 3 comments
Assignees
@obscuren
Labels
type:feature
Milestone
PoC7

Comments

@obscuren
Copy link
Contributor

Sub packages should drop their eth => prefix https://github.com/ethereum/eth-go/issues/38

  • ethchain chain
  • ethcrypto crypto
  • ethdb ???
  • ethlog logger
  • ethminer miner
  • ethpipe xeth
  • ethrpc rpc
  • ethstate state
  • ethtrie trie
  • ethvm vm
  • ethwire wire
@obscuren obscuren self-assigned this Oct 27, 2014
@obscuren obscuren added this to the PoC7 milestone Oct 27, 2014
@obscuren
Copy link
Contributor Author

Would be nice to finish this before PoC7 but isn't necessarily a show stopper. We could move this to PoC8.

@fjl
Copy link
Contributor

fjl commented Oct 30, 2014

We could also freeze the code for a few hours and rename everything. It's always going to be inconvenient. Better do it now just after the go-ethereum merge.

@obscuren
Copy link
Contributor Author

I've left ethdb intact. just db is too generic. We'd need a different name or leave it as ethdb

karalabe pushed a commit that referenced this issue Feb 15, 2018
@cooganb @karalabe
swarm: add favicon for Swarm templates served by browser (#15958)
4e61ed0 
* swarm: added script to HTML header to create favicon addresses #153

* swarm: moved data blob direclty into link tag, removed script

* swarm: added favicon info to other html templates

* swarm: fixing test errors

* swarm: fixing favicon test

* swarm: fixing travis tests

* swarm: added script to HTML header to create favicon addresses #153

* swarm: moved data blob direclty into link tag, removed script

* swarm: added favicon info to other html templates

* swarm: fixing test errors

* swarm: fixing favicon test

* swarm: fixing travis tests
prestonvanloon pushed a commit to prestonvanloon/go-ethereum that referenced this issue Apr 2, 2018
@cooganb @prestonvanloon
swarm: add favicon for Swarm templates served by browser (ethereum#15958
8b17b79 
)

* swarm: added script to HTML header to create favicon addresses ethereum#153

* swarm: moved data blob direclty into link tag, removed script

* swarm: added favicon info to other html templates

* swarm: fixing test errors

* swarm: fixing favicon test

* swarm: fixing travis tests

* swarm: added script to HTML header to create favicon addresses ethereum#153

* swarm: moved data blob direclty into link tag, removed script

* swarm: added favicon info to other html templates

* swarm: fixing test errors

* swarm: fixing favicon test

* swarm: fixing travis tests
mariameda pushed a commit to NiluPlatform/go-nilu that referenced this issue Aug 23, 2018
@cooganb @mariameda
swarm: add favicon for Swarm templates served by browser (ethereum#15958
d70bda0 
)

* swarm: added script to HTML header to create favicon addresses ethereum#153

* swarm: moved data blob direclty into link tag, removed script

* swarm: added favicon info to other html templates

* swarm: fixing test errors

* swarm: fixing favicon test

* swarm: fixing travis tests

* swarm: added script to HTML header to create favicon addresses ethereum#153

* swarm: moved data blob direclty into link tag, removed script

* swarm: added favicon info to other html templates

* swarm: fixing test errors

* swarm: fixing favicon test

* swarm: fixing travis tests
ngtuna added a commit to ngtuna/tomochain that referenced this issue Oct 4, 2018
@ngtuna
Merge pull request ethereum#153 from dinhln89/randomize
dacfcc7 
Randomization implementation
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
@kevjue
disabled goimport lint checks for now. also updated core/blockchain.g…
9f9f495 
…o imports to reflect geth's version (ethereum#153)
atenjin pushed a commit to alt-research/go-ethereum that referenced this issue Apr 4, 2024
@ajsutton
Merge pull request ethereum#153 from ethereum-optimism/update_v1_13_3
a1972f1 
Merge go-ethereum v1.13.2 (Phaistos) and v1.13.3 changes (Armeni)
s1na pushed a commit to s1na/go-ethereum that referenced this issue Dec 2, 2024
@wjrjerome
Merge pull request ethereum#153 from XinFinOrg/fix-block-write-read-r…
69cadcc 
…ace-condition

race condition caused by old eth bug where read before write. We fixi…
ryanschneider pushed a commit to ryanschneider/go-ethereum that referenced this issue Jan 30, 2025
@TymKh
expose revert reason and execution error (ethereum#153)
b996797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obscuren obscuren

Labels
type:feature
Projects
None yet
Milestone
PoC7
Development

No branches or pull requests
2 participants
@fjl @obscuren