Skip to content

Commit

Permalink
Merge pull request #817 from tgerring/rpcglog
Browse files Browse the repository at this point in the history
Remove old logger from RPC pkg
  • Loading branch information
obscuren committed Apr 27, 2015
2 parents f54c2e7 + 3ad5243 commit 182d484
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Automated (dev) builds
* Ubuntu
[trusty](https://build.ethdev.com/builds/Linux%20Go%20develop%20deb%20i386-trusty/latest/) |
[utopic](https://build.ethdev.com/builds/Linux%20Go%20develop%20deb%20i386-utopic/latest/)
* [Windows] Coming soon™
* [Windows 64-bit](https://build.ethdev.com/builds/Windows%20Go%20develop%20branch/Geth-Win64-latest.7z)

Executables
===========
Expand Down
6 changes: 3 additions & 3 deletions rpc/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ func (api *EthereumApi) GetRequestReply(req *RpcRequest, reply *interface{}) err
case "eth_mining":
*reply = api.xeth().IsMining()
case "eth_gasPrice":
v := xeth.DefaultGas()
*reply = newHexData(v.Bytes())
v := xeth.DefaultGasPrice()
*reply = newHexNum(v.Bytes())
case "eth_accounts":
*reply = api.xeth().Accounts()
case "eth_blockNumber":
Expand Down Expand Up @@ -489,6 +489,6 @@ func (api *EthereumApi) GetRequestReply(req *RpcRequest, reply *interface{}) err
return NewNotImplementedError(req.Method)
}

rpclogger.DebugDetailf("Reply: %T %s", reply, reply)
glog.V(logger.Detail).Infof("Reply: %T %s\n", reply, reply)
return nil
}
5 changes: 2 additions & 3 deletions rpc/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
"github.com/rs/cors"
)

var rpclogger = logger.NewLogger("RPC")
var rpclistener *stoppableTCPListener

const (
Expand All @@ -31,7 +30,7 @@ func Start(pipe *xeth.XEth, config RpcConfig) error {

l, err := newStoppableTCPListener(fmt.Sprintf("%s:%d", config.ListenAddress, config.ListenPort))
if err != nil {
rpclogger.Errorf("Can't listen on %s:%d: %v", config.ListenAddress, config.ListenPort, err)
glog.V(logger.Error).Infof("Can't listen on %s:%d: %v", config.ListenAddress, config.ListenPort, err)
return err
}
rpclistener = l
Expand Down Expand Up @@ -136,7 +135,7 @@ func send(writer io.Writer, v interface{}) (n int, err error) {
var payload []byte
payload, err = json.MarshalIndent(v, "", "\t")
if err != nil {
rpclogger.Fatalln("Error marshalling JSON", err)
glog.V(logger.Error).Infoln("Error marshalling JSON", err)
return 0, err
}
glog.V(logger.Detail).Infof("Sending payload: %s", payload)
Expand Down

0 comments on commit 182d484

Please sign in to comment.