Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(consume): use the session_temp_folder introduced in #824 #845

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix(consume): use the session_temp_folder introduced in #824 #845

merged 1 commit into from
Sep 27, 2024

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Sep 27, 2024 •
edited
Loading

🗒️ Description

Fix a small regression that crept in when introducing the concurrency plugin, #824

We need some basic smoke testing for consume asap.

🔗 Related Issues

#824

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md. skipped
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added type:bug Something isn't working scope:consume Scope: Consume command suite labels Sep 27, 2024
marioevz
marioevz approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, missed this one, sorry about that.

@danceratopz
Copy link
Member Author

LGTM, missed this one, sorry about that.

Me too! 🙂

@danceratopz danceratopz merged commit 6ae70a7 into main Sep 27, 2024
7 checks passed
@danceratopz danceratopz deleted the fix/consume/session_temp_folder branch September 27, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
scope:consume Scope: Consume command suite type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danceratopz @marioevz