Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EIP-7702: Updates for Devnet-3 #733

Merged
merged 57 commits into from
Sep 5, 2024
Merged

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Aug 7, 2024

πŸ—’οΈ Description

Introduces new tests and changes according to the latest EIP-7702 spec.

Requires #762

πŸ”— Related Issues

Fixes #703

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

pdobacz added a commit to ethereum/evmone that referenced this pull request Aug 8, 2024
@marioevz marioevz force-pushed the eip-7702-devnet-3 branch 3 times, most recently from 70ab500 to f374fa0 Compare August 13, 2024 23:42
@marioevz marioevz marked this pull request as ready for review August 13, 2024 23:43
@marioevz marioevz added the type:test Type: Add/refactor fw unit tests; no fw or el client test case changes label Aug 13, 2024
@marioevz marioevz marked this pull request as draft August 13, 2024 23:43
gumb0 pushed a commit to ethereum/evmone that referenced this pull request Aug 21, 2024
@marioevz marioevz force-pushed the eip-7702-devnet-3 branch 2 times, most recently from 396d51c to 136083a Compare August 27, 2024 19:35
@marioevz marioevz marked this pull request as ready for review August 27, 2024 19:52
gumb0 pushed a commit to ethereum/evmone that referenced this pull request Aug 28, 2024
gumb0 pushed a commit to ethereum/evmone that referenced this pull request Aug 29, 2024
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marioevz there's a few minor things below - I'm still grappling with tests. I wanted to get visibility of the parameter combinations (for test_gas_costs, in particular) and hacked something together quickly to visualize and sort the values by parameter. Here's the result, I hope it can help you to notice any missing coverage/combinations. If you think this is useful I can make a PR for the pytest plugin πŸ˜† that generated this.

Open the root folder in your browser πŸ™‚
7702-parametrized-cases-html.tar.gz

This could be added to the doc flow to help document test cases.

tests/prague/eip7702_set_code_tx/spec.py Outdated Show resolved Hide resolved
tests/prague/eip7702_set_code_tx/test_gas.py Outdated Show resolved Hide resolved
tests/prague/eip7702_set_code_tx/test_set_code_txs.py Outdated Show resolved Hide resolved
@marioevz
Copy link
Member Author

marioevz commented Sep 3, 2024

@marioevz there's a few minor things below - I'm still grappling with tests. I wanted to get visibility of the parameter combinations (for test_gas_costs, in particular) and hacked something together quickly to visualize and sort the values by parameter. Here's the result, I hope it can help you to notice any missing coverage/combinations. If you think this is useful I can make a PR for the pytest plugin πŸ˜† that generated this.

Open the root folder in your browser πŸ™‚ 7702-parametrized-cases-html.tar.gz

This could be added to the doc flow to help document test cases.

This is awesome, it looks really nice this way, do you think we could automatically generate this for the docs?

Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Happy for us to merge this if we wanted to create a new release. I plan to review this again properly but if there is anything else we can always add subsequent PRs.

@marioevz marioevz merged commit 59379a8 into main Sep 5, 2024
7 checks passed
@marioevz marioevz deleted the eip-7702-devnet-3 branch September 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:test Type: Add/refactor fw unit tests; no fw or el client test case changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remaining 7702 Tests for Devnet-3
5 participants