-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EIP-7702: Updates for Devnet-3 #733
Conversation
70ab500
to
f374fa0
Compare
f374fa0
to
80890f3
Compare
7933670
to
8dd0a5e
Compare
c1afe74
to
1e40a62
Compare
396d51c
to
136083a
Compare
β¦end_with_defaults (#758)
e70d831
to
16978ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marioevz there's a few minor things below - I'm still grappling with tests. I wanted to get visibility of the parameter combinations (for test_gas_costs
, in particular) and hacked something together quickly to visualize and sort the values by parameter. Here's the result, I hope it can help you to notice any missing coverage/combinations. If you think this is useful I can make a PR for the pytest plugin π that generated this.
Open the root folder in your browser π
7702-parametrized-cases-html.tar.gz
This could be added to the doc flow to help document test cases.
Co-authored-by: danceratopz <[email protected]>
This is awesome, it looks really nice this way, do you think we could automatically generate this for the docs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Happy for us to merge this if we wanted to create a new release. I plan to review this again properly but if there is anything else we can always add subsequent PRs.
ποΈ Description
Introduces new tests and changes according to the latest EIP-7702 spec.
Requires #762
π Related Issues
Fixes #703
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.