Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/filler): Index generation concurrency issue #725

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

marioevz
Copy link
Member

🗒️ Description

Fixes an issue that occurs due to the fixture collectors still producing fixtures while the index was being generated at the same time.

Solution is to use a file lock (like in the consume command) to only generate the index until the last fixture collector is being cleaned up.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added the type:bug Something isn't working label Jul 31, 2024
@marioevz marioevz requested a review from spencer-tb July 31, 2024 20:43
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment.

src/pytest_plugins/filler/filler.py Outdated Show resolved Hide resolved
@marioevz marioevz merged commit b45ee33 into main Jul 31, 2024
7 checks passed
@marioevz marioevz deleted the gen-index-concurrency-fix branch July 31, 2024 21:34
spencer-tb pushed a commit to spencer-tb/execution-spec-tests that referenced this pull request Aug 8, 2024
* fix(plugins/filler): Index generation concurrency issue

* changelog

* fix(plugins/filler): tests

* fix(plugins/filler): fix parameter group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants