Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): EOF - EIP-7620: Add more tests for validating EOF subcontainer kinds #676

Merged
merged 5 commits into from
Jul 11, 2024
Merged

new(tests): EOF - EIP-7620: Add more tests for validating EOF subcontainer kinds #676

merged 5 commits into from
Jul 11, 2024

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Jul 9, 2024 •
edited
Loading

🗒️ Description

Test cases that check subcontainer validation in a deeply nested subcontainer, and in code sections other than section 0.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@gumb0 gumb0 force-pushed the eof-validate-subcontainer-kinds-tests branch 2 times, most recently from 06d896e to cb3d307 Compare July 9, 2024 13:14
@gumb0 gumb0 marked this pull request as ready for review July 9, 2024 15:57
@gumb0 gumb0 force-pushed the eof-validate-subcontainer-kinds-tests branch from 8f86bf5 to 6a451c3 Compare July 9, 2024 15:58
@gumb0 gumb0 requested review from shemnon, marioevz and chfast July 9, 2024 15:58
marioevz
marioevz requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some comments.

tests/prague/eip7692_eof_v1/eip7620_eof_create/test_subcontainer_validation.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7620_eof_create/test_subcontainer_validation.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7620_eof_create/test_subcontainer_validation.py Show resolved Hide resolved
@gumb0 gumb0 force-pushed the eof-validate-subcontainer-kinds-tests branch from 6a451c3 to a3fadea Compare July 10, 2024 16:49
@marioevz marioevz mentioned this pull request Jul 10, 2024
Merged
8 tasks
@gumb0 gumb0 force-pushed the eof-validate-subcontainer-kinds-tests branch from 9b070ad to 6962a07 Compare July 11, 2024 09:51
@gumb0 gumb0 requested a review from marioevz July 11, 2024 10:18
marioevz
marioevz approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two small suggestions, plus we should rebase before merging. Thanks!

tests/prague/eip7692_eof_v1/eip7620_eof_create/test_subcontainer_validation.py Outdated Show resolved Hide resolved
tests/prague/eip7692_eof_v1/eip7620_eof_create/test_subcontainer_validation.py Outdated Show resolved Hide resolved
@marioevz
Copy link
Member

Also, could we add this PR to the changelog in the same format as other EOF PRs? Thanks.

@gumb0 gumb0 force-pushed the eof-validate-subcontainer-kinds-tests branch from 6962a07 to 132542c Compare July 11, 2024 15:17
@marioevz marioevz changed the title Add more tests for validating EOF subcontainer kinds new(tests): EOF - EIP-7620: Add more tests for validating EOF subcontainer kinds Jul 11, 2024
@marioevz marioevz merged commit a60adc2 into ethereum:main Jul 11, 2024
4 checks passed
@marioevz marioevz deleted the eof-validate-subcontainer-kinds-tests branch July 11, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

@shemnon shemnon Awaiting requested review from shemnon

@chfast chfast Awaiting requested review from chfast

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gumb0 @marioevz