-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): update test case examples alongside docs #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
added a commit
to danceratopz/execution-spec-tests
that referenced
this pull request
May 29, 2023
Two of the examples in the tutorial content are not yet included in the repository, see ethereum#54 (bad_opcode) ethereum#61 (blockchain_example). As these examples are not merged and not yet converted to pytest format, they've been temporarily removed from the doc.
danceratopz
added a commit
to danceratopz/execution-spec-tests
that referenced
this pull request
Jun 1, 2023
Two of the examples in the tutorial content are not yet included in the repository, see ethereum#54 (bad_opcode) ethereum#61 (blockchain_example). As these examples are not merged and not yet converted to pytest format, they've been temporarily removed from the doc.
We should update the state test getting started in this PR, as it's now out of date regarding new framework test writing standards. |
6 tasks
* all: Add `converted-ethereum-tests.txt` file * github: Add checkbox for `converted-ethereum-tests.txt` to template
pypy doesn't name this parameter for some reason.
Co-authored-by: Mario Vega <[email protected]> Co-authored-by: danceratopz <[email protected]> Co-authored-by: spencer-tb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope:docs
Scope: Documentation
scope:tests
Scope: Changes EL client test cases in `./tests`
type:feat
type: Feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
An override of the initial PR (that initially added a blockchain test example to the EEST fillers). This is overridden due to significant framework changes.
The PR now adds an updated blockchain test case example, to coincide with the state test yul example.
These will be documented as tutorials within the EEST documentation.
The blockchain example utilizes the new Transactions generator dataclass: #435.
🔗 Related Issues
None.
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.