test(fw): add empty account tests #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
added
type:bug
danceratopz
reviewed
Apr 8, 2024
There was a problem hiding this comment.
Good catch!
Just a suggestion for readability and checking None storage values - added a few tests for that.
There's no changelog entry. I'd suggest that if we think it's not required, we should make a comment in the pr description next to the item in the todo list. I think it's borderline in this case 🙂
Update src/ethereum_test_tools/tests/test_types.py Co-authored-by: danceratopz <[email protected]>
marioevz
force-pushed
the
add-empty-account-test
branch
from
d73d333 to
46566ac
Compare
danceratopz
approved these changes
Apr 10, 2024
danceratopz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Fixes empty accounts not being recognized as such because an explicit zero was set as the value to a key.
Edit(dan): The original intent of this PR was also fixed in #486 and this PR now only adds additional tests for empty accounts and one small refactor.
🔗 Related Issues
Fixes #475
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.