Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forks,fw): Fix transition forks on state tests #406

Merged

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jan 26, 2024

🗒️ Description

Fix state test generated using transition forks, so the transition fork is not named in the output fixture, but the actual Fork that should be enabled according to the state test's block number and timestamp.

🔗 Related Issues

Fixes #405

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added type:bug Something isn't working scope:forks Scope: Changes ethereum_test_forks package labels Jan 26, 2024
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spencer-tb spencer-tb merged commit c6ebfc5 into ethereum:main Jan 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:forks Scope: Changes ethereum_test_forks package type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid fork name ShanghaiToCancunAtTime15k in state_tests.
2 participants