-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/statetest: Convert most blockchain tests #370
feat/statetest: Convert most blockchain tests #370
Conversation
4eee500
to
e62d568
Compare
d05ce2c
to
77f43cf
Compare
966c4ae
to
965d0a1
Compare
965d0a1
to
099bd9d
Compare
099bd9d
to
95d12c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one comment!
- tests/cancun/eip4844_blobs/test_point_evaluation_precompile.py::test_point_evaluation_precompile_before_fork | ||
- tests/cancun/eip7516_blobgasfee/test_blobgasfee_opcode.py::test_blobbasefee_before_fork | ||
- tests/shanghai/eip3860_initcode/test_initcode.py::test_contract_creating_tx | ||
- tests/shanghai/eip3860_initcode/test_initcode.py::TestContractCreationGasUsage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am being pedantic here, but should it not be:
- tests/shanghai/eip3860_initcode/test_initcode.py::TestContractCreationGasUsage | |
- tests/shanghai/eip3860_initcode/test_initcode.py::test_gas_usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was because this was generated with a test class instead of a test function, so if we change the id here, it will point to an nonexistent test.
I think the case can be made that we change the ids of all of the test classes, just for them to be cohesive with the rest of the names, but I'm not really sure how to do it.
🗒️ Description
env
in theStateTest
class.Requirements
All merged
#369, #368🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.