Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add python 3.12 support #309

Merged
merged 8 commits into from
Sep 26, 2023
Merged

chore: add python 3.12 support #309

merged 8 commits into from
Sep 26, 2023

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented Sep 24, 2023 •
edited by spencer-tb
Loading

🗒️ Description

  • Adds Python 3.12 support.
  • 3.12 tested (currently pre-release) in Github Actions.
  • Upgrades flake8.

Tested with 3.12.0rc3 built via pyenv.

The same version of flake8 (6.0.0) produced more warnings on Python 3.12 vs 3.10/3.11 (so these are fixed). But, since our flake8 version requirement in setup.cfg didn't make any sense (flake8>=5,<=6, note the <=6), I bumped this version to ensure we use patches/improvements in v6. Practically as of now, it means we'll use 6.1.0 instead of 6.0.0.

✅ Checklist

  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Considered squashing commits to improve commit history.

spencer-tb
spencer-tb approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Tested on macOS using pyenv install 3.12.0rc1.

I think we just need to rebase onto main, and re-update the changelog

@spencer-tb spencer-tb added scope:tools Scope: Changes ethereum_test_tools package scope:tests Scope: Changes EL client test cases in `./tests` scope:docs Scope: Documentation type:chore Type: Chore labels Sep 26, 2023
@spencer-tb spencer-tb added scope:fw Scope: Framework (evm|tools|forks|pytest) scope:tools Scope: Changes ethereum_test_tools package scope:tests Scope: Changes EL client test cases in `./tests` scope:ci Scope: Continuous Integration and removed scope:tools Scope: Changes ethereum_test_tools package scope:tests Scope: Changes EL client test cases in `./tests` scope:docs Scope: Documentation scope:fw Scope: Framework (evm|tools|forks|pytest) labels Sep 26, 2023
@spencer-tb spencer-tb force-pushed the chore/add-python-3.12-support branch from a35f4fe to 84d16af Compare September 26, 2023 22:12
@spencer-tb spencer-tb mentioned this pull request Sep 26, 2023
Closed
@spencer-tb spencer-tb merged commit bf714a3 into ethereum:main Sep 26, 2023
@danceratopz danceratopz deleted the chore/add-python-3.12-support branch September 28, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

Assignees
No one assigned
Labels
scope:ci Scope: Continuous Integration scope:tests Scope: Changes EL client test cases in `./tests` scope:tools Scope: Changes ethereum_test_tools package type:chore Type: Chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danceratopz @spencer-tb