feat(plugins/consume): Check port 8551 on Engine API tests #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
added
type:bug
16 tasks
danceratopz
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Great catch! ❤️
Excuse me being pedantic, but I'd prefer not to shadow an existing fixture and keep the client startup config in one place. Made a suggestion in #1098.
* Revert "feat(plugins/consume): Check 8551 port on Engine tests" This reverts commit e248a3b. * style(consume): string formatting auto-fixes from ruff * style(consume): use one-liner docstrings. * fix(consume): configure HIVE_CHECK_LIVE_PORT via dedicated fixture
fselmo
pushed a commit
to fselmo/execution-spec-tests
that referenced
this pull request
Jan 24, 2025
codeofcarson
pushed a commit
to codeofcarson/execution-spec-tests
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Use the
"HIVE_CHECK_LIVE_PORT"client environment value when starting a client for an Engine API test in theconsumecommand.This seems to be a recurrent issue when instantiating parallel client containers for hive runs, as it can be seen in https://hive.pectra-devnet-5.ethpandaops.io/suite.html?suiteid=1737336360-cdc9f3b55f2e828c17ab8b6c364934e8.json&suitename=eest%2Fconsume-engine#
The solution suggested by this PR is to signal hive to wait for the Engine API port (8551) instead of the RPC port (8545) before returning the client to the simulator (
consume).🔗 Related Issues
None
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.