test: Workaround GCC 12 warning at -O3 #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
approved these changes
Aug 22, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #691 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 86 86
Lines 8236 8236
=======================================
Hits 8033 8033
Misses 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
|
When compiling `code = {0x00}` with GCC 12 -O3 it detects a false
positive buffer overflow and gives a warning. Workaround it by using
explicit `code = bytes{0x00}`.
```
/usr/include/c++/12/bits/char_traits.h:268:23: error: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ accessing 9223372036854775810 or more bytes at offsets -4611686018427387902 and [-4611686018427387903, 4611686018427387904] may overlap up to 9223372036854775813 bytes at offset -3 [-Werror=restrict]
268 | __builtin_memcpy(__s1, __s2, __n * sizeof(char_type));
| ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
The warning is gone in GCC 13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling
code = {0x00}with GCC 12 -O3 it detects a false positive buffer overflow and gives a warning. Workaround it by using explicitcode = bytes{0x00}.The warning is gone in GCC 13.