EVM-C update #108
Merged
EVM-C update #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
evmc
branch
3 times, most recently
from
b666038 to
acf60f7
Compare
gcolvin
reviewed
Dec 26, 2016
| /// The function has to be named as `<vm-name>_get_interface(void)`. | ||
| /// Each EVM implementation is obligated to provided a function returning | ||
| /// an EVM instance. | ||
| /// The function has to be named as `<vm-name>_get_factory(void)`. |
There was a problem hiding this comment.
Why does the function have to have a particular form of name?
There was a problem hiding this comment.
This is more convention than strict requirement. I was also thinking about having a registry of VM implementation, where you could get one by name... But this is not worth the trouble.
|
Sorry, I didn't manage to look at this yet. |
The evm_result was planned to be used as the return struct of the call callback. The address was added to support CREATE, but it is never used and the union here confuses many languages like Go and Python.
Replace evm_interface with evm_factory. The factory provides ABI protection and the function for creating EVM instances. After the instance is create you can discard the factory as it is no longer needed.
We try to avoid C ABI complex rules like passing structs by value to increase portability.
In evm_query_fn, return result by explicit output parameter to avoid C ABI issues and inrease portability. C compiler would do the same implicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview of proposed EVM-C changes. Currently, users have to carry 2 objects: EVM-C interface and instance. Interface describes ABI version and set of "virtual" functions to manage instances. This is inconvenient as users typically create single interface and single instance but need to have both to execute any code.
This PR propose a change to always create an EVM instance, "virtual" functions are included in the instance object. Still initialization must be perform in two steps (create and init), because we want (do we?) init step to be able to be changed in future ABI versions.
I have not updated any comments around the changes yet, sorry.