-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java: add proper lint task to CI #581
Conversation
Current failures:
|
@@ -8,6 +8,9 @@ SOURCE_DIR = $(realpath $(CURDIR)/../..) | |||
OUT_DIR = $(CURDIR)/c/build | |||
BUILD_DIR = $(OUT_DIR)/_cmake_build | |||
|
|||
lint: gradlew | |||
./gradlew --no-daemon clean spotlessCheck | |||
|
|||
build: gradlew $(OUT_DIR)/lib/libevmc-java.so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also make build depend on lint. And rename the gradlew task to gradle-setup. And reorder the file.
- run: | ||
name: "Java Test" | ||
command: | | ||
cd bindings/java && make test | ||
command: cd bindings/java && make test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove these whitespaces changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #559 (comment)