revert removal of aggregate deduplication condition from #2183 #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djrtwo
force-pushed
the
revert-dupe-condition
branch
from
51f7650 to
03f0f67
Compare
arnetheduck
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This condition removal (#2225) that was released in Altair was reverted in all clients after observing additional load due to the gossip amplification factor.
This condition halts duplicates from getting far in the gossip, but then these duplicates are still picked up in gossipsub's IWANT/IHAVE. This means that messages still eventually make it across the network but do not suffer the gossip amplification factor.
More discussion here #2183