Revise participation tracking in light client #2810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current mechanism to track historic sync committee participation is suboptimal in these aspects: - During sync, `LightClientUpdate` are fetched across multiple sync committee periods. The sync participation may change drastically over time. If any of those synced periods had unusually high participation and is followed by periods of unusually low participation, this may prevent optimistic header updates until `current_slot` has advanced sufficiently (from the sync time, not from the update time). - When the light client suspends, `process_slot_for_light_client_store` needs to be called for all missed slots after resuming, which is not practical (optimizations would be possible). This patch changes the rollover of the tracked participation to happen whenever the `store.finalized_header`'s sync committee period advances. While in sync with the network, rollovers happen at the same frequency as before, but this guarantees that participation is no longer mixed across multiple sync committee periods, avoiding the problems above.
|
|
This PR is no longer necessary, as other light client sync protocol updates will replace the automated force-update based on wall clock with a manual trigger based on heuristics depending on the risk profile of the corresponding use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current mechanism to track historic sync committee participation is
suboptimal in these aspects:
LightClientUpdateare fetched across multiple synccommittee periods. The sync participation may change drastically over
time. If any of those synced periods had unusually high participation
and is followed by periods of unusually low participation, this may
prevent optimistic header updates until
current_slothas advancedsufficiently (from the sync time, not from the update time).
process_slot_for_light_client_storeneeds to be called for all missed slots after resuming, which is not
practical (optimizations would be possible).
This patch changes the rollover of the tracked participation to happen
whenever the
store.finalized_header's sync committee period advances.While in sync with the network, rollovers happen at the same frequency
as before, but this guarantees that participation is no longer mixed
across multiple sync committee periods, avoiding the problems above.