Fix get_pow_block_at_terminal_total_difficulty
and add unit tests
#2726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2722
Spec changes
get_pow_block_at_terminal_total_difficulty
was wrongly iteratingpow_chain
keys. It should be dict valuespow_chain.values()
instead ofpow_chain
.block.parent_hash == Hash32() and block.parent_hash not in pow_chain
. Without handling it, it would raiseKeyErorr
in pyspec.New concern: it's the first time to usefixedcontinue
in specs. Is it too Pythonic and difficult to do formal verification?Testing
Add unit tests for
get_pow_block_at_terminal_total_difficulty