New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type definition for get_attestation_slot #1050

Closed

sorpaas opened this issue May 5, 2019 · 1 comment

sorpaas commented May 5, 2019

get_attestation_slot expects Attestation, but get_matching_head_attestations uses it as if it is PendingAttestation.

The text was updated successfully, but these errors were encountered:

Contributor

JustinDrake commented May 5, 2019

Well spotted. We should should make get_attestation_slot consume AttestationData (as opposed to either Attestation or PendingAttestation).

djrtwo closed this as completed in

2c3bbac

djrtwo added a commit that referenced this issue


          Merge pull request #1051 from ethereum/JustinDrake-patch-22

5c2bca4

Fix #1050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment