Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add windows-gnu to rust tests #531

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

Rjected
Copy link
Contributor

@Rjected Rjected commented Jan 22, 2025

This allows the build script to work with windows-gnu, by using flag_if_supported on the /std:c11 flag, and gating the i32 repr change to msvc.

@Rjected Rjected force-pushed the try-windows-workflow branch 2 times, most recently from e7f2b1a to a78454d Compare January 22, 2025 23:18
@Rjected Rjected closed this Jan 22, 2025
@Rjected Rjected force-pushed the try-windows-workflow branch from a78454d to 98f9921 Compare January 22, 2025 23:23
@Rjected Rjected reopened this Jan 22, 2025
@Rjected Rjected force-pushed the try-windows-workflow branch from 98f9921 to c465504 Compare January 22, 2025 23:29
@Rjected Rjected marked this pull request as ready for review January 22, 2025 23:51
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM, thank you!

@jtraglia jtraglia merged commit af3c0b8 into ethereum:main Jan 23, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants