Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the build system #483

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

jtraglia
Copy link
Member

This makes a few notable improvements to the build system:

  • If the blst submodule has been updated, it will re-build & copy files.
  • Do not build object files individually. The build prints won't show now.
    • I kind of liked this though, because it ensured imports were correct.
  • Add prints for each rule, so the developer knows what's going on.
  • Also, fix build for profiler (it was using too much stack).
  • Also, build blst in the Java bindings. If the library didn't exist, it would error.

@jtraglia jtraglia requested a review from asn-d6 August 13, 2024 17:23
@jtraglia
Copy link
Member Author

Should be non-controversial. George said it worked for him last week. Going to merge.

@jtraglia jtraglia merged commit de4f9eb into ethereum:main Aug 15, 2024
38 checks passed
@jtraglia jtraglia deleted the improve-build-system branch August 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant