Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FFT functions to fft.{c,h} files #466

Merged
merged 6 commits into from
Aug 5, 2024
Merged

Move FFT functions to fft.{c,h} files #466

merged 6 commits into from
Aug 5, 2024

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Aug 1, 2024

Move the *_{i,}fft functions (except for coset_{i,}fft) to a new fft.c file. Exposed via fft.h.

@jtraglia jtraglia requested a review from asn-d6 August 1, 2024 15:38
asn-d6
asn-d6 requested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some comments!

src/ckzg.c Show resolved Hide resolved
src/tests.c Show resolved Hide resolved
src/Makefile Outdated Show resolved Hide resolved
asn-d6
asn-d6 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@asn-d6 asn-d6 merged commit 4db29c6 into ethereum:main Aug 5, 2024
38 checks passed
@jtraglia jtraglia deleted the fft-file branch August 5, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asn-d6 asn-d6 asn-d6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtraglia @asn-d6