Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): move Rust bindings to KZGSettings #461

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Jul 19, 2024

This moves the public functions to KZGSettings. And we no longer need to pass &kzg_settings as an argument.

Associated with #413.

@asn-d6
Copy link
Contributor

asn-d6 commented Jul 19, 2024

Hmm. I think this is fine, but I have no strong feelings on this PR in either direction.

I will let @mattsse decide if it works better for their codebase.

IIUC this is a non-backwards compatible change and Lighthouse will also need to adjust their codebase.

Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should work but I believe these functions could be kept on Kzgcommitment for backwards compat and then the new fns on kzgsettings would call them?

@jtraglia
Copy link
Member Author

I believe these functions could be kept on Kzgcommitment for backwards compat and then the new fns on kzgsettings would call them?

Hmm that would work too, but it feels a little confusing. I'm okay with breaking backwards compatibility this time. It's a good time to do this, as we're going to make a v2 release soon-ish. I like having all the public functions accessible in the same way.

@mattsse
Copy link
Contributor

mattsse commented Jul 19, 2024

changes should be minimal, @Rjected for vis

@Rjected
Copy link
Contributor

Rjected commented Jul 22, 2024

This API makes sense to me, fine with updating our code when the new version is released

Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@asn-d6 asn-d6 merged commit 4ec4285 into ethereum:main Jul 24, 2024
38 checks passed
@jtraglia jtraglia deleted the rust-pub-fns-in-settings branch August 1, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants