Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recovery code to match specs #459

Merged
merged 23 commits into from
Jul 20, 2024
Merged

Update recovery code to match specs #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b208b0b
chore: add code to compute Z(x) by shifting the polynomial
kevaundray Jul 19, 2024
75d7038
chore: add test for both ways to compute Z(x)
kevaundray Jul 19, 2024
40e52e0
assert -> ASSERT
kevaundray Jul 19, 2024
c8dbe65
change test order
kevaundray Jul 19, 2024
97f24e8
rename zero_polynomial -> vanishing_polynomial
kevaundray Jul 19, 2024
0d54f0e
ASSERT requires a message, whereas `assert` does not
kevaundray Jul 19, 2024
07778a0
use ben's suggestion of `vanishing_polynomial_for_missing_cells`
kevaundray Jul 19, 2024
4ee5503
Update src/c_kzg_4844.c
kevaundray Jul 19, 2024
e03b9af
return C_KZG_BAD_ARGS, when `vanishing_polynomial_for_missing_cells` …
kevaundray Jul 19, 2024
f9c58f2
Bens comment: make the domain explicit
kevaundray Jul 19, 2024
263e655
remove poly_t (now unused)
kevaundray Jul 19, 2024
c14f535
remove MAX_WIDTH constant from test and use s.max_width (we can make …
kevaundray Jul 19, 2024
832f6ad
remove vanishing_poly_len
kevaundray Jul 19, 2024
2e814f3
remove comment mentioning `vanishing_poly_len` -- doesn't add much, m…
kevaundray Jul 19, 2024
2081244
link explanation to expanded_roots_of_unity
kevaundray Jul 19, 2024
989bf6e
add remark about roots
kevaundray Jul 19, 2024
2d1b3e0
Update src/c_kzg_4844.c
kevaundray Jul 19, 2024
bf4c002
justin review + formatting
kevaundray Jul 19, 2024
a629159
Update src/c_kzg_4844.c
kevaundray Jul 19, 2024
bf2521d
format
kevaundray Jul 19, 2024
ebbbfc1
Fix comment style in core C file
jtraglia Jul 19, 2024
a633b48
Use /* */ style comments in test file
jtraglia Jul 19, 2024
35d12e9
Remove unnecessary ret = OK line
jtraglia Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading