Add central Makefile which builds/tests everything #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asn-d6
reviewed
Jul 19, 2024
| .PHONY: rust | ||
| rust: | ||
| @cargo test --features generate-bindings | ||
| @cargo bench --no-run |
There was a problem hiding this comment.
I was not expecting to see the benches getting run. I thought this would just build and run tests.
No strong opinion.
(PR LGTM other than this)
There was a problem hiding this comment.
This doesn't run the benchmarks, just builds them; see the --no-run flag.
But this did remind me to disable benchmarks for Java bindings. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on EIP-7594 support, it was pretty annoying building/testing each of the bindings individually. I would have to cd bindings/ && && cd ../bindings/ a bunch of times. This PR adds a Makefile to the repository root which will build and test everything.