Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase column limit to 100 for C code #456

Merged
merged 12 commits into from
Jul 24, 2024

Conversation

jtraglia
Copy link
Member

This PR changes the column limit from 80 to 100. George and I had discussed how annoying the 80 char limit is. We agreed that to raise it 100, a value that modern languages like Rust and Go adhere to.

@jtraglia jtraglia requested a review from asn-d6 July 18, 2024 17:52
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Not merging so as to not create merge conflicts with the other PRs.

Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@asn-d6 asn-d6 merged commit 09628a4 into ethereum:main Jul 24, 2024
38 checks passed
@jtraglia jtraglia deleted the increase-column-limit branch August 1, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants