Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): Add ethereum kzg settings #443

Merged
merged 7 commits into from
Jun 27, 2024

Conversation

rakita
Copy link
Contributor

@rakita rakita commented Jun 24, 2024

Adds ethereum_kzg_settings and ethereum_kzg_settings_arc functions behind a feature gate.

This would allow directly using eth trusted setup and consolidating revm/alloy/reth repos. Ref bluealloy/revm#1553

@rakita rakita changed the title feat: Add ethereum kzg settings feat(rust): Add ethereum kzg settings Jun 24, 2024
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me! Thanks 😃

In the past, I have been against using the trusted setup from this repo outside of testing. But this is a feature that clients (Reth + Lodestar) have requested. I think it's important that we listen to the clients, so I support this.

@rakita
Copy link
Contributor Author

rakita commented Jun 26, 2024

Seems reasonable to me! Thanks 😃

In the past, I have been against using the trusted setup from this repo outside of testing. But this is a feature that clients (Reth + Lodestar) have requested. I think it's important that we listen to the clients, so I support this.

It is hidden behind a rust feature flag, and a nice thing about that is that it is optional for a compilation. It is very useful to have it, especially Arc version.

@asn-d6
Copy link
Contributor

asn-d6 commented Jun 27, 2024

Looks good but would appreciate a code review by another member of the reth team (or lighthouse even). Can you arrange this @rakita, if possible?

@jtraglia Am I right to think that this makes #440 "easier" to port from DAS to main because now the file parsing happens inside the bindings and not in the clients?

@jtraglia
Copy link
Member

Am I right to think that this makes #440 "easier" to port from DAS to main

Um maybe. I'll pull in these changes into the das branch, so merging back into main isn't really a concern.

@rakita
Copy link
Contributor Author

rakita commented Jun 27, 2024

Looks good but would appreciate a code review by another member of the reth team (or lighthouse even). Can you arrange this @rakita, if possible?

@jtraglia Am I right to think that this makes #440 "easier" to port from DAS to main because now the file parsing happens inside the bindings and not in the clients?

Make sense, will ask for a volunteer :)

Copy link

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj

@jtraglia jtraglia merged commit 69616da into ethereum:main Jun 27, 2024
38 checks passed
@rakita rakita deleted the eth_kzg_settings branch June 28, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants