-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): Add ethereum kzg settings #443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me! Thanks 😃
In the past, I have been against using the trusted setup from this repo outside of testing. But this is a feature that clients (Reth + Lodestar) have requested. I think it's important that we listen to the clients, so I support this.
It is hidden behind a rust feature flag, and a nice thing about that is that it is optional for a compilation. It is very useful to have it, especially |
Looks good but would appreciate a code review by another member of the reth team (or lighthouse even). Can you arrange this @rakita, if possible? @jtraglia Am I right to think that this makes #440 "easier" to port from DAS to main because now the file parsing happens inside the bindings and not in the clients? |
Um maybe. I'll pull in these changes into the das branch, so merging back into main isn't really a concern. |
Make sense, will ask for a volunteer :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gj
Adds
ethereum_kzg_settings
andethereum_kzg_settings_arc
functions behind a feature gate.This would allow directly using eth trusted setup and consolidating revm/alloy/reth repos. Ref bluealloy/revm#1553