Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify how default setup is found #424

Merged

Conversation

matthewkeil
Copy link
Member

Simplifies the logic for importing the default trusted_setup.txt in the node.js bindings.

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthewkeil this does look better.

@matthewkeil
Copy link
Member Author

Thanks @matthewkeil this does look better.

Welcome! Will just make sure @asn-d6 also likes the fix and will let him merge if its ok

@asn-d6
Copy link
Contributor

asn-d6 commented May 3, 2024

Thanks! Merging.

@asn-d6 asn-d6 merged commit c9e4634 into ethereum:main May 3, 2024
38 checks passed
@jtraglia jtraglia deleted the mkeil/simplify-default-setup-config branch May 3, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants