Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken nodejs/csharp CI tests #420

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Fix broken nodejs/csharp CI tests #420

merged 6 commits into from
Apr 29, 2024

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Apr 29, 2024 •
edited
Loading

Noticed some issues with macOS on these tests. This PR investigates & fixes these issues.

  • For the nodejs tests, Python wasn't properly setup first.
    • This prevented setuptools from being installed.
  • For csharp, macos-latest now defaults to an arm64 runner.
    • We were attempting to use the x86_64 library, which failed to load.

Also, 🔥🔥🔥

@jtraglia jtraglia marked this pull request as ready for review April 29, 2024 16:41
asn-d6
asn-d6 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@asn-d6 asn-d6 merged commit 58b09bd into ethereum:main Apr 29, 2024
38 checks passed
@jtraglia jtraglia deleted the fix-ci-workflows branch April 29, 2024 20:15
3Y215

This comment was marked as spam.

Sign in to view

3Y215

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3Y215 3Y215 3Y215 left review comments

@asn-d6 asn-d6 asn-d6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtraglia @asn-d6 @3Y215