Support Rust no_std environments
#347
Conversation
There was a problem hiding this comment.
Nice, I like these changes. Thanks! Just one thing I'd like to point out (see my comment below), but it's not your problem. I'd like to have @asn-d6 and @pawanjay176 also review this before merging.
| v.push(Blob::from_hex(blob)?); | ||
| } | ||
| return Ok(v); | ||
| self.blobs.iter().map(|blob| Blob::from_hex(blob)).collect() |
There was a problem hiding this comment.
For some reason, this change causes a stack overflow for me; testing on an M1 MacBook Air. This isn't really your problem though. I suspect it will be resolved if/when we start boxing blobs.
There was a problem hiding this comment.
Looks like it's failing in CI as well, will revert
DaniPopes
force-pushed
the
no_std
branch
2 times, most recently
from
88484a8 to
1ef16a9
Compare
|
Should be good now |
|
@DaniPopes Ah sorry, that windows stack overflow issue is unrelated to your PR. We just fixed this. See:
You just need to pull in changes from main. Thanks for your work on this 🥇 |
Add a "std" feature flag to the Rust bindings, enabled by default, which when disabled by consumers with
no-default-features = trueactivates#![no_std]attribute.This is achieved by using
allocfor ownedStringandVec, and using&CStrinstead of&Pathwhenstdis not available.I've also included some small warnings and lint fixes.