Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blst's generator functions #340

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

jtraglia
Copy link
Member

Minor complexity improvement. Rather than redefining the G1/G2 generators, use blst's blst_p{1,2}_generator functions. These return pointers which will most likely get plugged in during comptime, so there's no performance penalty.

Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asn-d6 asn-d6 merged commit 9e68a47 into ethereum:main Aug 14, 2023
@jtraglia jtraglia deleted the use-generator-funcs branch August 14, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants